Generation II is my favorite, but Gen IV is a close second.
Granted, Gen II is also when I grew bored of Pokemon, which didn't revive until I found a bundle pack of Ruby+Sapphire+Game Guide at Target. So the 3rd Generation brought me back to the games, and eventually drew me into the online community.